Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/wasm/wasm-opcodes.h

Issue 2165633006: [wasm] Remove special memory type for (internal) globals and use local type instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: [wasm] Remove special memory type for (internal) globals and use local type instead. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-module.h ('k') | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-opcodes.h
diff --git a/src/wasm/wasm-opcodes.h b/src/wasm/wasm-opcodes.h
index 37b684755b3dbf44c455905c21f15317e365baeb..819b897bcc975d644aa8e751e4e68e6c2d16e99f 100644
--- a/src/wasm/wasm-opcodes.h
+++ b/src/wasm/wasm-opcodes.h
@@ -22,21 +22,6 @@ enum LocalTypeCode {
kLocalS128 = 5
};
-// Binary encoding of memory types.
-enum MemTypeCode {
- kMemI8 = 0,
- kMemU8 = 1,
- kMemI16 = 2,
- kMemU16 = 3,
- kMemI32 = 4,
- kMemU32 = 5,
- kMemI64 = 6,
- kMemU64 = 7,
- kMemF32 = 8,
- kMemF64 = 9,
- kMemS128 = 10
-};
-
// We reuse the internal machine type to represent WebAssembly AST types.
// A typedef improves readability without adding a whole new type system.
typedef MachineRepresentation LocalType;
@@ -531,35 +516,6 @@ class WasmOpcodes {
}
}
- static MemTypeCode MemTypeCodeFor(MachineType type) {
- if (type == MachineType::Int8()) {
- return kMemI8;
- } else if (type == MachineType::Uint8()) {
- return kMemU8;
- } else if (type == MachineType::Int16()) {
- return kMemI16;
- } else if (type == MachineType::Uint16()) {
- return kMemU16;
- } else if (type == MachineType::Int32()) {
- return kMemI32;
- } else if (type == MachineType::Uint32()) {
- return kMemU32;
- } else if (type == MachineType::Int64()) {
- return kMemI64;
- } else if (type == MachineType::Uint64()) {
- return kMemU64;
- } else if (type == MachineType::Float32()) {
- return kMemF32;
- } else if (type == MachineType::Float64()) {
- return kMemF64;
- } else if (type == MachineType::Simd128()) {
- return kMemS128;
- } else {
- UNREACHABLE();
- return kMemI32;
- }
- }
-
static MachineType MachineTypeFor(LocalType type) {
switch (type) {
case kAstI32:
« no previous file with comments | « src/wasm/wasm-module.h ('k') | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698