Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/builtins/mips64/builtins-mips64.cc

Issue 2165633003: Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/mips/builtins-mips.cc ('k') | src/builtins/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 1172 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 RelocInfo::CODE_TARGET); 1183 RelocInfo::CODE_TARGET);
1184 } else { 1184 } else {
1185 DCHECK_EQ(function_type, CallableType::kAny); 1185 DCHECK_EQ(function_type, CallableType::kAny);
1186 __ Jump(masm->isolate()->builtins()->Call(ConvertReceiverMode::kAny, 1186 __ Jump(masm->isolate()->builtins()->Call(ConvertReceiverMode::kAny,
1187 tail_call_mode), 1187 tail_call_mode),
1188 RelocInfo::CODE_TARGET); 1188 RelocInfo::CODE_TARGET);
1189 } 1189 }
1190 } 1190 }
1191 1191
1192 // static 1192 // static
1193 void Builtins::Generate_InterpreterPushArgsAndConstructImpl( 1193 void Builtins::Generate_InterpreterPushArgsAndConstruct(MacroAssembler* masm) {
1194 MacroAssembler* masm, CallableType construct_type) {
1195 // ----------- S t a t e ------------- 1194 // ----------- S t a t e -------------
1196 // -- a0 : argument count (not including receiver) 1195 // -- a0 : argument count (not including receiver)
1197 // -- a3 : new target 1196 // -- a3 : new target
1198 // -- a1 : constructor to call 1197 // -- a1 : constructor to call
1199 // -- a2 : address of the first argument 1198 // -- a2 : address of the first argument
1200 // ----------------------------------- 1199 // -----------------------------------
1201 1200
1202 // Find the address of the last argument. 1201 // Find the address of the last argument.
1203 __ dsll(t0, a0, kPointerSizeLog2); 1202 __ dsll(t0, a0, kPointerSizeLog2);
1204 __ Dsubu(t0, a2, Operand(t0)); 1203 __ Dsubu(t0, a2, Operand(t0));
1205 1204
1206 // Push a slot for the receiver. 1205 // Push a slot for the receiver.
1207 __ push(zero_reg); 1206 __ push(zero_reg);
1208 1207
1209 // Push the arguments. 1208 // Push the arguments.
1210 Label loop_header, loop_check; 1209 Label loop_header, loop_check;
1211 __ Branch(&loop_check); 1210 __ Branch(&loop_check);
1212 __ bind(&loop_header); 1211 __ bind(&loop_header);
1213 __ ld(t1, MemOperand(a2)); 1212 __ ld(t1, MemOperand(a2));
1214 __ Daddu(a2, a2, Operand(-kPointerSize)); 1213 __ Daddu(a2, a2, Operand(-kPointerSize));
1215 __ push(t1); 1214 __ push(t1);
1216 __ bind(&loop_check); 1215 __ bind(&loop_check);
1217 __ Branch(&loop_header, gt, a2, Operand(t0)); 1216 __ Branch(&loop_header, gt, a2, Operand(t0));
1218 1217
1219 if (construct_type == CallableType::kJSFunction) { 1218 // Call the constructor with a0, a1, and a3 unmodified.
1220 // TODO(mythria): Change this when allocation site feedback is available. 1219 __ Jump(masm->isolate()->builtins()->Construct(), RelocInfo::CODE_TARGET);
1221 // ConstructFunction initializes allocation site to undefined.
1222 __ Jump(masm->isolate()->builtins()->ConstructFunction(),
1223 RelocInfo::CODE_TARGET);
1224 } else {
1225 DCHECK_EQ(construct_type, CallableType::kAny);
1226 // Call the constructor with a0, a1, and a3 unmodified.
1227 __ Jump(masm->isolate()->builtins()->Construct(), RelocInfo::CODE_TARGET);
1228 }
1229 } 1220 }
1230 1221
1231 void Builtins::Generate_InterpreterEnterBytecodeDispatch(MacroAssembler* masm) { 1222 void Builtins::Generate_InterpreterEnterBytecodeDispatch(MacroAssembler* masm) {
1232 // Set the return address to the correct point in the interpreter entry 1223 // Set the return address to the correct point in the interpreter entry
1233 // trampoline. 1224 // trampoline.
1234 Smi* interpreter_entry_return_pc_offset( 1225 Smi* interpreter_entry_return_pc_offset(
1235 masm->isolate()->heap()->interpreter_entry_return_pc_offset()); 1226 masm->isolate()->heap()->interpreter_entry_return_pc_offset());
1236 DCHECK_NE(interpreter_entry_return_pc_offset, Smi::FromInt(0)); 1227 DCHECK_NE(interpreter_entry_return_pc_offset, Smi::FromInt(0));
1237 __ li(t0, Operand(masm->isolate()->builtins()->InterpreterEntryTrampoline())); 1228 __ li(t0, Operand(masm->isolate()->builtins()->InterpreterEntryTrampoline()));
1238 __ Daddu(ra, t0, Operand(interpreter_entry_return_pc_offset->value() + 1229 __ Daddu(ra, t0, Operand(interpreter_entry_return_pc_offset->value() +
(...skipping 1746 matching lines...) Expand 10 before | Expand all | Expand 10 after
2985 __ break_(0xCC); 2976 __ break_(0xCC);
2986 } 2977 }
2987 } 2978 }
2988 2979
2989 #undef __ 2980 #undef __
2990 2981
2991 } // namespace internal 2982 } // namespace internal
2992 } // namespace v8 2983 } // namespace v8
2993 2984
2994 #endif // V8_TARGET_ARCH_MIPS64 2985 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/builtins/mips/builtins-mips.cc ('k') | src/builtins/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698