Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2165633003: Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler (Closed)

Created:
4 years, 5 months ago by mythria
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler (patchset #6 id:100001 of https://codereview.chromium.org/2153433002/ ) Reason for revert: This cl causes a large regression in octane (https://chromeperf.appspot.com/group_report?bug_id=629503). I have to investigate the reason before I can reland this. Original issue's description: > [Interpreter] Collect type feedback for 'new' in the bytecode handler > > Collect type feedback in the bytecode handler for 'new' bytecode. The > current implementation does not collect allocation site feedback. > > BUG=v8:4280, v8:4780 > LOG=N > > Committed: https://crrev.com/1eadc76419b323fb2e55ae9953142f801704aa59 > Cr-Commit-Position: refs/heads/master@{#37862} TBR=rmcilroy@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4780 Committed: https://crrev.com/b4012176751767b1f2e58f9ac32520cb443ab2bd Cr-Commit-Position: refs/heads/master@{#37872}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -300 lines) Patch
M src/builtins/arm/builtins-arm.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/builtins/builtins.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/builtins/builtins.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 3 chunks +6 lines, -146 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +12 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallNew.golden View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mythria
Created Revert of [Interpreter] Collect type feedback for 'new' in the bytecode handler
4 years, 5 months ago (2016-07-19 14:15:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165633003/1
4 years, 5 months ago (2016-07-19 14:16:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 14:16:14 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 14:17:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4012176751767b1f2e58f9ac32520cb443ab2bd
Cr-Commit-Position: refs/heads/master@{#37872}

Powered by Google App Engine
This is Rietveld 408576698