Upgrade to Opus 1.1.3.

Upgrade to Opus 1.1.3.

BUG=

Committed: https://crrev.com/89f50bf2af0e51d11de422f67adb7153a3065145
Cr-Commit-Position: refs/heads/master@{#407822}

[flim-chromium, 2016-07-19 12:46:18]

The CQ bit was checked by flim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 14:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 14:08:44]

Dry run: This issue passed the CQ dry run.

[flim-chromium, 2016-07-22 14:16:09]

flim@chromium.org changed reviewers:
+ henrika@chromium.org, minyue@chromium.org

[flim-chromium, 2016-07-22 14:16:10]

Hi, could you please review this update?

[henrika (OOO until Aug 14), 2016-07-25 11:21:00]

I don't know the technical details of Opus. Expect minyue@ to check those parts.

LGTM from my side

[flim-chromium, 2016-07-26 12:14:46]

The CQ bit was checked by flim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 12:14:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[flim-chromium, 2016-07-26 12:30:59]

Description was changed from

==========
Upgrade to Opus 1.1.3.

This also changes checks for NEON support to be independent of checks
for RTCD (run time CPU detection) support.

BUG=
==========

to

==========
Upgrade to Opus 1.1.3.

BUG=
==========

[flim-chromium, 2016-07-26 12:33:14]

I've updated it so that the neon optimizations rely on RTCD checks instead of
being standalone.

[minyue, 2016-07-26 12:57:32]

On 2016/07/26 12:33:14, flim-chromium wrote:
> I've updated it so that the neon optimizations rely on RTCD checks instead of
> being standalone.

I like this. The idea is that we always build optimizations and let runtime
decide which cpu arch to use.
Drawback is that it only works on RTCD enabled OS.

[minyue, 2016-07-26 12:58:39]

https://codereview.chromium.org/2165633002/diff/20001/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/2165633002/diff/20001/third_party/opus/opus.g...
third_party/opus/opus.gyp:162: 'include_dirs': [
why this?

[flim-chromium, 2016-07-26 13:05:47]

https://codereview.chromium.org/2165633002/diff/20001/third_party/opus/opus.gyp
File third_party/opus/opus.gyp (right):

https://codereview.chromium.org/2165633002/diff/20001/third_party/opus/opus.g...
third_party/opus/opus.gyp:162: 'include_dirs': [
On 2016/07/26 12:58:39, minyue wrote:
> why this?

In the new file silk/arm/NSQ_neon.c, it has "#include "celt/*.h", so we need to
add "src" so that it can find "src/celt/*.h", where "src" here refers to
"third_party/opus/src"

[minyue, 2016-07-26 13:09:07]

lgtm

[commit-bot: I haz the power, 2016-07-26 13:15:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 13:15:09]

Dry run: This issue passed the CQ dry run.

[flim-chromium, 2016-07-26 16:10:38]

The CQ bit was checked by flim@chromium.org

[flim-chromium, 2016-07-26 16:10:39]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@chromium.org
Link to the patchset: https://codereview.chromium.org/2165633002/#ps20001
(title: "Move NEON optimization back inside the RTCD check")

[commit-bot: I haz the power, 2016-07-26 16:10:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 16:14:08]

Description was changed from

==========
Upgrade to Opus 1.1.3.

BUG=
==========

to

==========
Upgrade to Opus 1.1.3.

BUG=
==========

[commit-bot: I haz the power, 2016-07-26 16:14:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 16:15:31]

Description was changed from

==========
Upgrade to Opus 1.1.3.

BUG=
==========

to

==========
Upgrade to Opus 1.1.3.

BUG=

Committed: https://crrev.com/89f50bf2af0e51d11de422f67adb7153a3065145
Cr-Commit-Position: refs/heads/master@{#407822}
==========

[commit-bot: I haz the power, 2016-07-26 16:15:33]

Patchset 2 (id:??) landed as
https://crrev.com/89f50bf2af0e51d11de422f67adb7153a3065145
Cr-Commit-Position: refs/heads/master@{#407822}