Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: Source/core/svg/SVGFontFaceSource.h

Issue 216563002: [SVG Fonts] Fix <font-face> element leak document (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGFontFaceElement.cpp ('k') | Source/core/svg/SVGFontFaceSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGFontFaceSource.h
diff --git a/Source/core/svg/SVGFontFaceSource.h b/Source/core/svg/SVGFontFaceSource.h
index 9211727a89e0865f1fc712dd172bfb7c6efc32de..2ddd526669e8ef8b0425ab6546672a84f81b5493 100644
--- a/Source/core/svg/SVGFontFaceSource.h
+++ b/Source/core/svg/SVGFontFaceSource.h
@@ -15,12 +15,14 @@ class SVGFontFaceElement;
class SVGFontFaceSource : public CSSFontFaceSource {
public:
- SVGFontFaceSource(PassRefPtr<SVGFontFaceElement>);
+ SVGFontFaceSource(SVGFontFaceElement*);
private:
virtual PassRefPtr<SimpleFontData> createFontData(const FontDescription&) OVERRIDE;
- RefPtr<SVGFontFaceElement> m_svgFontFaceElement;
+ // This is a raw ptr as the element resides in the same document as the FontFace. This is to avoid a reference cycle.
+ // FIXME: Oilpan: This should be a Member when we move SVGFontFaceElement to oilpan.
+ SVGFontFaceElement* m_svgFontFaceElement;
};
} // namespace WebCore
« no previous file with comments | « Source/core/svg/SVGFontFaceElement.cpp ('k') | Source/core/svg/SVGFontFaceSource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698