Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2165623002: tryserver.chromium.perf: convert chromium_trybot builders to remote_run (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

tryserver.chromium.perf: convert chromium_trybot builders to remote_run BUG=593999, 584079 Committed: https://chromium.googlesource.com/chromium/tools/build/+/df7e807bd6359285880dcf9d7fda7ba5e6c9bfb4

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M masters/master.tryserver.chromium.perf/master.cfg View 3 chunks +16 lines, -1 line 4 comments Download

Messages

Total messages: 13 (7 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-19 12:39:13 UTC) #2
tandrii(chromium)
https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.chromium.perf/master.cfg File masters/master.tryserver.chromium.perf/master.cfg (right): https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.chromium.perf/master.cfg#newcode28 masters/master.tryserver.chromium.perf/master.cfg:28: if not factory_properties: why do you need this and ...
4 years, 5 months ago (2016-07-19 12:44:33 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.chromium.perf/master.cfg File masters/master.tryserver.chromium.perf/master.cfg (right): https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.chromium.perf/master.cfg#newcode28 masters/master.tryserver.chromium.perf/master.cfg:28: if not factory_properties: On 2016/07/19 at 12:44:32, tandrii(chromium) wrote: ...
4 years, 5 months ago (2016-07-19 12:49:30 UTC) #8
tandrii(chromium)
LGTM https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.chromium.perf/master.cfg File masters/master.tryserver.chromium.perf/master.cfg (right): https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.chromium.perf/master.cfg#newcode28 masters/master.tryserver.chromium.perf/master.cfg:28: if not factory_properties: On 2016/07/19 12:49:30, Paweł Hajdan ...
4 years, 5 months ago (2016-07-19 12:58:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165623002/1
4 years, 5 months ago (2016-07-19 12:59:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 13:03:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/df7e807bd6359285880d...

Powered by Google App Engine
This is Rietveld 408576698