tryserver.chromium.perf: convert chromium_trybot builders to remote_run

tryserver.chromium.perf: convert chromium_trybot builders to remote_run

BUG=593999, 584079
Committed: https://chromium.googlesource.com/chromium/tools/build/+/df7e807bd6359285880dcf9d7fda7ba5e6c9bfb4

[Paweł Hajdan Jr., 2016-07-19 12:39:12]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Paweł Hajdan Jr., 2016-07-19 12:39:16]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:39:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 12:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 12:43:37]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-07-19 12:44:33]

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.perf/master.cfg (right):

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.perf/master.cfg:28: if not factory_properties:
why do you need this and below condition if it's never true?

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.perf/master.cfg:72: 'build_url':
master_config.GetGSUtilUrl('chrome-perf', upload_dir)}
because of this... (see other comment)

[Paweł Hajdan Jr., 2016-07-19 12:49:30]

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.perf/master.cfg (right):

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.perf/master.cfg:28: if not factory_properties:
On 2016/07/19 at 12:44:32, tandrii(chromium) wrote:
> why do you need this and below condition if it's never true?

It's reasonably generic and uniform with e.g. chromium.gpu.fyi .

We already duplicate this function, but at least I'm trying to limit the number
of variants.

Does that make sense? I'm fine with changing it if you insist - it's just a
tradeoff either way. Ideally it'll all disappear as we migrate off buildbot.

[tandrii(chromium), 2016-07-19 12:58:29]

LGTM

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.perf/master.cfg (right):

https://codereview.chromium.org/2165623002/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.perf/master.cfg:28: if not factory_properties:
On 2016/07/19 12:49:30, Paweł Hajdan Jr. wrote:
> On 2016/07/19 at 12:44:32, tandrii(chromium) wrote:
> > why do you need this and below condition if it's never true?
> 
> It's reasonably generic and uniform with e.g. chromium.gpu.fyi .
> 
> We already duplicate this function, but at least I'm trying to limit the
number
> of variants.
> 
> Does that make sense? I'm fine with changing it if you insist - it's just a
> tradeoff either way. Ideally it'll all disappear as we migrate off buildbot.

fair enough.

[Paweł Hajdan Jr., 2016-07-19 12:59:29]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-07-19 12:59:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:03:46]

Description was changed from

==========
tryserver.chromium.perf: convert chromium_trybot builders to remote_run

BUG=593999, 584079
==========

to

==========
tryserver.chromium.perf: convert chromium_trybot builders to remote_run

BUG=593999, 584079

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/df7e807bd6359285880d...
==========

[commit-bot: I haz the power, 2016-07-19 13:03:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/df7e807bd6359285880d...