Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2165593002: [builtins] Move builtins into own files (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Move builtins into own files R=yangguo@chromium.org BUG=v8:5197 Committed: https://crrev.com/d4ad10b30f5cb4606a60cb6af388efb473b24567 Cr-Commit-Position: refs/heads/master@{#37885}

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn #

Patch Set 3 : Move more builtins #

Patch Set 4 : Rebase #

Total comments: 1

Patch Set 5 : Rebase #

Patch Set 6 : Remove builtins-error.cc from BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4933 lines, -4686 lines) Patch
M BUILD.gn View 1 2 3 5 1 chunk +17 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 4 2 chunks +5 lines, -0 lines 0 comments Download
M src/builtins/builtins.cc View 1 2 3 4 5 chunks +136 lines, -4686 lines 0 comments Download
A src/builtins/builtins-arraybuffer.cc View 1 2 1 chunk +88 lines, -0 lines 0 comments Download
A src/builtins/builtins-boolean.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A src/builtins/builtins-dataview.cc View 1 2 1 chunk +146 lines, -0 lines 0 comments Download
A src/builtins/builtins-date.cc View 1 chunk +1002 lines, -0 lines 0 comments Download
A src/builtins/builtins-function.cc View 1 2 1 chunk +300 lines, -0 lines 0 comments Download
A src/builtins/builtins-global.cc View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
A src/builtins/builtins-internal.cc View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A src/builtins/builtins-json.cc View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A src/builtins/builtins-math.cc View 1 2 1 chunk +561 lines, -0 lines 0 comments Download
A src/builtins/builtins-number.cc View 1 chunk +235 lines, -0 lines 0 comments Download
A src/builtins/builtins-object.cc View 1 2 1 chunk +914 lines, -0 lines 0 comments Download
A src/builtins/builtins-proxy.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A src/builtins/builtins-reflect.cc View 1 chunk +274 lines, -0 lines 0 comments Download
A src/builtins/builtins-sharedarraybuffer.cc View 1 2 1 chunk +266 lines, -0 lines 0 comments Download
A src/builtins/builtins-string.cc View 1 chunk +529 lines, -0 lines 0 comments Download
A src/builtins/builtins-symbol.cc View 1 chunk +76 lines, -0 lines 0 comments Download
A src/builtins/builtins-typedarray.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 35 (26 generated)
jgruber
4 years, 5 months ago (2016-07-19 12:51:58 UTC) #16
Yang
Awesome. LGTM! https://codereview.chromium.org/2165593002/diff/60001/src/builtins/builtins.h File src/builtins/builtins.h (right): https://codereview.chromium.org/2165593002/diff/60001/src/builtins/builtins.h#newcode582 src/builtins/builtins.h:582: static MaybeHandle<JSFunction> CompileString(Handle<Context> context, Let's move this ...
4 years, 5 months ago (2016-07-19 15:00:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165593002/60001
4 years, 5 months ago (2016-07-19 15:00:20 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19771)
4 years, 5 months ago (2016-07-19 15:03:27 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165593002/80001
4 years, 5 months ago (2016-07-20 06:51:25 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/5258) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-20 06:54:17 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165593002/100001
4 years, 5 months ago (2016-07-20 06:56:15 UTC) #31
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-20 07:38:21 UTC) #33
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 07:38:52 UTC) #35
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d4ad10b30f5cb4606a60cb6af388efb473b24567
Cr-Commit-Position: refs/heads/master@{#37885}

Powered by Google App Engine
This is Rietveld 408576698