third_party/WebKit/Source/web/tests/WebDocumentTest.cpp - Issue 2165573003: Simplify tests by using Web*Impl types directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebDocumentTest.cpp

Issue 2165573003: Simplify tests by using Web*Impl types directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebDocumentTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp b/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp

index 850d7cdc628cd06e23e885832b8b99456b296420..df85b0788a6019e65f53f783946ca0d38211d8bd 100644

--- a/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebDocumentTest.cpp

@@ -52,7 +52,7 @@ void WebDocumentTest::loadURL(const std::string& url)

Document* WebDocumentTest::topDocument() const

{

- return toLocalFrame(m_webViewHelper.webViewImpl()->page()->mainFrame())->document();

+ return toLocalFrame(m_webViewHelper.webView()->page()->mainFrame())->document();

}

WebDocument WebDocumentTest::topWebDocument() const

@@ -216,12 +216,12 @@ void WebDocumentFirstPartyTest::load(const char* file)

Document* WebDocumentFirstPartyTest::nestedDocument() const

{

- return toLocalFrame(m_webViewHelper.webViewImpl()->page()->mainFrame()->tree().firstChild())->document();

+ return toLocalFrame(m_webViewHelper.webView()->page()->mainFrame()->tree().firstChild())->document();

}

Document* WebDocumentFirstPartyTest::nestedNestedDocument() const

{

- return toLocalFrame(m_webViewHelper.webViewImpl()->page()->mainFrame()->tree().firstChild()->tree().firstChild())->document();

+ return toLocalFrame(m_webViewHelper.webView()->page()->mainFrame()->tree().firstChild()->tree().firstChild())->document();

}

TEST_F(WebDocumentFirstPartyTest, Empty)