third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2165573003: Simplify tests by using Web*Impl types directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2165573003: Simplify tests by using Web*Impl types directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 39265c6150240c3d3702687e45f451cfc5be8c94..3a967e9a0ac0bcb20e14996131eb8b6782ae879d 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -162,8 +162,8 @@ public:

return webScrollLayer;

}

- WebViewImpl* webViewImpl() const { return m_helper.webViewImpl(); }

- LocalFrame* frame() const { return m_helper.webViewImpl()->mainFrameImpl()->frame(); }

+ WebViewImpl* webViewImpl() const { return m_helper.webView(); }

+ LocalFrame* frame() const { return m_helper.webView()->mainFrameImpl()->frame(); }

static void configureSettings(WebSettings* settings)

{