third_party/WebKit/Source/web/tests/TopControlsTest.cpp - Issue 2165573003: Simplify tests by using Web*Impl types directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

Issue 2165573003: Simplify tests by using Web*Impl types directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/TopControlsTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

index 42af87a8b541ac9aac38d108d18d2ca511fb962d..5bfcf267eb728e240f8a0877c0d9f0e9c4193257 100644

--- a/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

+++ b/third_party/WebKit/Source/web/tests/TopControlsTest.cpp

@@ -129,9 +129,9 @@ public:

}

- WebViewImpl* webViewImpl() const { return m_helper.webViewImpl(); }

- LocalFrame* frame() const { return m_helper.webViewImpl()->mainFrameImpl()->frame(); }

- VisualViewport& visualViewport() const { return m_helper.webViewImpl()->page()->frameHost().visualViewport(); }

+ WebViewImpl* webViewImpl() const { return m_helper.webView(); }

+ LocalFrame* frame() const { return m_helper.webView()->mainFrameImpl()->frame(); }

+ VisualViewport& visualViewport() const { return m_helper.webView()->page()->frameHost().visualViewport(); }

private:

std::string m_baseURL;