third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp - Issue 2165573003: Simplify tests by using Web*Impl types directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

Issue 2165573003: Simplify tests by using Web*Impl types directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp b/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

index 763c01b35efbc327f12406eec101133ab06fd31d..7d23579c67c90fecc156183245a569f014d8a656 100644

--- a/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp

@@ -120,7 +120,7 @@ protected:

{

FrameTestHelpers::loadFrame(m_helper.webView()->mainFrame(), KURL(m_baseUrl, url).getString().utf8().data());

FrameSerializer serializer(m_resources, *this);

- Frame* frame = m_helper.webViewImpl()->mainFrameImpl()->frame();

+ Frame* frame = m_helper.webView()->mainFrameImpl()->frame();

for (; frame; frame = frame->tree().traverseNext()) {

// This is safe, because tests do not do cross-site navigation

// (and therefore don't have remote frames).