Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp

Issue 2165573003: Simplify tests by using Web*Impl types directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
index a999ac8af20fccb36ac88a526f4f0535fcc1aa96..6cbf7bda20b9811a812f2cb019ba182a7f7ac555 100644
--- a/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
@@ -72,8 +72,8 @@ protected:
m_activityLogger = new TestActivityLogger();
V8DOMActivityLogger::setActivityLogger(isolatedWorldId, String(), wrapUnique(m_activityLogger));
m_webViewHelper.initialize(true);
- m_scriptController = &m_webViewHelper.webViewImpl()->mainFrameImpl()->frame()->script();
- FrameTestHelpers::loadFrame(m_webViewHelper.webViewImpl()->mainFrame(), "about:blank");
+ m_scriptController = &m_webViewHelper.webView()->mainFrameImpl()->frame()->script();
+ FrameTestHelpers::loadFrame(m_webViewHelper.webView()->mainFrame(), "about:blank");
}
~ActivityLoggerTest()
@@ -85,7 +85,7 @@ protected:
{
v8::HandleScope scope(v8::Isolate::GetCurrent());
m_scriptController->executeScriptInMainWorld(script);
- pumpPendingRequestsForFrameToLoad(m_webViewHelper.webViewImpl()->mainFrame());
+ pumpPendingRequestsForFrameToLoad(m_webViewHelper.webView()->mainFrame());
}
void executeScriptInIsolatedWorld(const String& script) const
@@ -95,7 +95,7 @@ protected:
sources.append(ScriptSourceCode(script));
Vector<v8::Local<v8::Value>> results;
m_scriptController->executeScriptInIsolatedWorld(isolatedWorldId, sources, extensionGroup, 0);
- pumpPendingRequestsForFrameToLoad(m_webViewHelper.webViewImpl()->mainFrame());
+ pumpPendingRequestsForFrameToLoad(m_webViewHelper.webView()->mainFrame());
}
bool verifyActivities(const String& activities)

Powered by Google App Engine
This is Rietveld 408576698