third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp - Issue 2165573003: Simplify tests by using Web*Impl types directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

Issue 2165573003: Simplify tests by using Web*Impl types directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

index a48b89b2e02bac5222ce08bc5ea228367f3f11d7..a2701f5411f446d01416e8efd3b3a8f6be62b39c 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

@@ -125,9 +125,9 @@ protected:

webView()->updateAllLifecyclePhases();

}

- WebViewImpl* webView() const { return m_helper.webViewImpl(); }

+ WebViewImpl* webView() const { return m_helper.webView(); }

const ExternalPopupMenuWebFrameClient& client() const { return m_webFrameClient; }

- WebLocalFrameImpl* mainFrame() const { return m_helper.webViewImpl()->mainFrameImpl(); }

+ WebLocalFrameImpl* mainFrame() const { return m_helper.webView()->mainFrameImpl(); }

private:

std::string m_baseURL;