Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2165533002: MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' (Closed)

Created:
4 years, 5 months ago by Marija Antic
Modified:
4 years, 5 months ago
Reviewers:
ivica.bogosavljevic, balazs.kilvady, miran.karic, ilija.pavlovic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= Committed: https://crrev.com/dcf8251ecfec4e7884db5a6e9618f6847fe0363f Cr-Commit-Position: refs/heads/master@{#37861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Marija Antic
PTAL
4 years, 5 months ago (2016-07-19 09:42:28 UTC) #2
balazs.kilvady
lgtm with a note: Please change the Port of ... line to Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 in ...
4 years, 5 months ago (2016-07-19 10:36:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165533002/1
4 years, 5 months ago (2016-07-19 11:05:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 11:08:28 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 11:08:30 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 11:10:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcf8251ecfec4e7884db5a6e9618f6847fe0363f
Cr-Commit-Position: refs/heads/master@{#37861}

Powered by Google App Engine
This is Rietveld 408576698