Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Marija Antic Modified:
4 years, 5 months ago Reviewers:
ivica.bogosavljevic, balazs.kilvady, miran.karic, ilija.pavlovic, akos.palfi.imgtec CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionMIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.'
Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996
Failing on r6 due to wrong registers used in macro assembler.
TEST=test-run-machops/RunInt32MulWithOverflowImm
BUG=
Committed: https://crrev.com/dcf8251ecfec4e7884db5a6e9618f6847fe0363f
Cr-Commit-Position: refs/heads/master@{#37861}
Patch Set 1 #
Created: 4 years, 5 months ago
Messages
Total messages: 15 (9 generated)
PTAL
lgtm with a note: Please change the Port of ... line to Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 in the description.
Description was changed from ========== MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port of https://codereview.chromium.org/2101123005/ Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= ========== to ========== MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= ==========
The CQ bit was checked by marija.antic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by marija.antic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= ========== to ========== MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= ========== to ========== MIPS: Fix 'Port [turbofan] Introduce integer multiplication with overflow.' Port 8e18a5f2a0357c6899cd32f5ab66b73d72fdd996 Failing on r6 due to wrong registers used in macro assembler. TEST=test-run-machops/RunInt32MulWithOverflowImm BUG= Committed: https://crrev.com/dcf8251ecfec4e7884db5a6e9618f6847fe0363f Cr-Commit-Position: refs/heads/master@{#37861} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dcf8251ecfec4e7884db5a6e9618f6847fe0363f Cr-Commit-Position: refs/heads/master@{#37861} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
