Issue 216553003: Disable painting in a few more places

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216553003: Disable painting in a few more places (Closed)

Created:
6 years, 9 months ago by Sami

Modified:
6 years, 9 months ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Disable painting in a few more places When GraphicsContext is given a NULL canvas, it should disable painting. This patch amends a few operations where this check wasn't done. Most notably, we no longer record display lists when painting is disabled. BUG=357572 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170332

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nit. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -12 lines)			Patch
	M	Source/platform/graphics/GraphicsContext.cpp	View	1	7 chunks	+30 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Stephen Chennney

LGTM with a nit. https://codereview.chromium.org/216553003/diff/1/Source/platform/graphics/GraphicsContext.cpp File Source/platform/graphics/GraphicsContext.cpp (right): https://codereview.chromium.org/216553003/diff/1/Source/platform/graphics/GraphicsContext.cpp#newcode494 Source/platform/graphics/GraphicsContext.cpp:494: if (!paintingDisabled()) { This can ...

6 years, 9 months ago (2014-03-28 12:47:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/216553003/20001

6 years, 9 months ago (2014-03-28 14:06:42 UTC) #4

Message was sent while issue was closed.

Change committed as 170332

Expand Messages | Collapse Messages