Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis@'s comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index b636ed7eeac27488e1d5e80f2e24b0a33c7cc7d3..9ea712100954a33594c13137f99f563279a4e0cb 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -40,11 +40,11 @@
#include "content/common/site_isolation_policy.h"
#include "content/common/view_messages.h"
#include "content/public/browser/content_browser_client.h"
+#include "content/public/browser/guest_mode.h"
lfg 2016/09/23 16:23:02 I think this isn't used anymore.
EhsanK 2016/09/23 20:40:23 Sorry I missed this one out. Submitted a patch to
#include "content/public/browser/render_process_host_observer.h"
#include "content/public/browser/render_widget_host_iterator.h"
#include "content/public/browser/render_widget_host_view.h"
#include "content/public/browser/user_metrics.h"
-#include "content/public/common/browser_plugin_guest_mode.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/content_switches.h"
#include "content/public/common/referrer.h"
@@ -1825,7 +1825,8 @@ void RenderFrameHostManager::EnsureRenderViewInitialized(
void RenderFrameHostManager::CreateOuterDelegateProxy(
SiteInstance* outer_contents_site_instance,
RenderFrameHostImpl* render_frame_host) {
- CHECK(BrowserPluginGuestMode::UseCrossProcessFramesForGuests());
+ // We only get here when Delegate for this manager is an inner delegate and is
+ // based on cross process frames.
RenderFrameProxyHost* proxy =
CreateRenderFrameProxyHost(outer_contents_site_instance, nullptr);

Powered by Google App Engine
This is Rietveld 408576698