Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed an Error in Code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index ed316e45611a80bd7fdb1c84c13a64e86d009e9d..f283befd6a8139cdc31a5687463a1bfa2b9d8100 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -199,7 +199,12 @@ gfx::Vector2dF RenderWidgetHostViewChildFrame::GetLastScrollOffset() const {
}
gfx::NativeView RenderWidgetHostViewChildFrame::GetNativeView() const {
- NOTREACHED();
+ // TODO(ekaramad): To accomodate MimeHandlerViewGuest while embedded inside
+ // OOPIF-webview, we need to return the native view to be used by
+ // RenderWidgetHostViewGuest. Remove this once https://crbug.com/642826 is
+ // fixed.
+ if (frame_connector_)
+ return frame_connector_->GetParentRenderWidgetHostView()->GetNativeView();
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698