components/guest_view/browser/guest_view_base.h - Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.h

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return Top-Level WebContents View's NativeView rather than Owners Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/guest_view/browser/guest_view_base.h

diff --git a/components/guest_view/browser/guest_view_base.h b/components/guest_view/browser/guest_view_base.h

index 320a5e4d50b269831aeb861b657a7c3d3f4646df..f847153b2f914ad8371572aa93188d8b240d013c 100644

--- a/components/guest_view/browser/guest_view_base.h

+++ b/components/guest_view/browser/guest_view_base.h

@@ -84,6 +84,11 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

static bool IsGuest(content::WebContents* web_contents);

+ // TODO(ekaramad): This is used in forcing MimeHandlerView always use a

+ // BrowserPlugin rather than <iframe> (OOPIF). Remove this when we fix

+ // https://crbug.com/563285.

+ static bool IsForMimeHandlerViewGuest(content::WebContents* web_contents);

// Returns the name of the derived type of this GuestView.

virtual const char* GetViewType() const = 0;