Force MimeHandlerView to always use BrowserPlugin

chrome/browser/renderer_context_menu/render_view_context_menu.cc

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 210adc6d75d706936ca9186a699bc107e60d67e6..912a74c6ecfc0000bede946a126eb5c35d491882 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -74,6 +74,7 @@
 #include "components/autofill/core/common/password_generation_util.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
 #include "components/google/core/browser/google_util.h"
+#include "components/guest_view/browser/guest_view_base.h"
 #include "components/metrics/proto/omnibox_input_type.pb.h"
 #include "components/omnibox/browser/autocomplete_classifier.h"
 #include "components/omnibox/browser/autocomplete_match.h"
@@ -108,6 +109,7 @@
 #include "content/public/common/url_utils.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_system.h"
+#include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h"
 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/extension.h"
@@ -500,7 +502,13 @@ gfx::Vector2d RenderViewContextMenu::GetOffset(
 #if defined(ENABLE_EXTENSIONS)
   // When --use-cross-process-frames-for-guests is enabled, the position is
   // transformed in the browser process hittesting code.
-  if (!content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests()) {
+  // TODO(ekaramad): For now, MimeHandlerView is based on BrowserPlugin even
+  // when guests use OOPIF. Remove the check below when MimeHandlerView is also
+  // based on OOPIF (https://crbug.com/563285).
+  WebContents* web_contents =
+      WebContents::FromRenderFrameHost(render_frame_host);
+  if (!content::BrowserPluginGuestMode::UseCrossProcessFramesForGuests() ||

[lazyboy, 2016/07/22 01:03:30]

I think the CL has too many BPGuestMode::UseCrossProcessFramesForGuests() &&
IsMimeHandlerView... type of constructs, I suggest you consider adding a method
BrowserPluginGuestMode::UseCrossProcessFramesForWebContents(WebContents*), since
this is in content, you'd want to go through browser_plugin_delegate to decide
whether it is mime handler view in addition to checking the switch value.


Also there are other places than this CL diff where
UseCrossProcessFramesForGuests is used, do we not want to update those places?

[EhsanK, 2016/07/27 22:34:47]

There is more instances of UseCross... but I found them not relevant. I will
prepare a list of all those that I have not changed and we can discuss them
offline.

Also, I added a method to BPGM as suggested. It will get GuestView from
WebContents and check if it is MimeHandlerViewGuest. However, this method cannot
be used that much around the code base because the map which holds
(web_contents, guest_view) is not updated from the get go. It happens sometime
during initialization.

+      guest_view::GuestViewBase::IsForMimeHandlerViewGuest(web_contents)) {
     WebContents* web_contents =
         WebContents::FromRenderFrameHost(render_frame_host);
     WebContents* top_level_web_contents =