Force MimeHandlerView to always use BrowserPlugin

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 335 matching lines @@
 void RenderWidgetHostViewGuest::InitAsFullscreen(
     RenderWidgetHostView* reference_host_view) {
   // This should never get called.
   NOTREACHED();
 }
 
 gfx::NativeView RenderWidgetHostViewGuest::GetNativeView() const {
   if (!guest_)
     return gfx::NativeView();
 
-  RenderWidgetHostView* rwhv = guest_->GetOwnerRenderWidgetHostView();
+  if (guest_->IsMimeHandlerViewGuest())
+    return guest_->GetTopLevelRenderWidgetHostView()->GetNativeView();

[lfg, 2016/07/20 19:49:57]

What's the problem when returning the OwnerRenderWidgetHostView() ?

[EhsanK, 2016/07/20 20:49:19]

When we show a PDF inside an OOPIF-<webview>, the owner's RWHV is a
RWHVChildFrame. But RWHVCF::GetNativeView() is NOTIMPLEMENTED().

Now my question is, what stops us from using top-level in all scenarios?  i.e.,
just return GetTopLevelRenderWidgetHost()->GetNativeView() regardless of whether
this is a mime handler or not.

[lfg, 2016/07/20 21:05:34]

In that case, shouldn't IsMimeHandlerViewGuest() return false?
Right, the other question I have is why are we calling GetNativeView() on the
guest? I'd rather try to clean this up before adding
GetTopLevelRenderWidgetHostView() to RenderWidgetHostViewGuest.

[EhsanK, 2016/07/21 19:53:06]

This is called from tests as well as used in sending screen rects. That being
said, whether or not we keep this in, wjmclean@ is about to add something like
GetTopLevelRWHV() to RWHVCF. I can then rebase after his CL lands.

+
+  RenderWidgetHostView* rwhv = GetOwnerRenderWidgetHostView();
   if (!rwhv)
     return gfx::NativeView();
+
   return rwhv->GetNativeView();
 }
 
 gfx::NativeViewAccessible RenderWidgetHostViewGuest::GetNativeViewAccessible() {
   if (!guest_)
     return gfx::NativeViewAccessible();
 
   RenderWidgetHostView* rwhv = guest_->GetOwnerRenderWidgetHostView();
   if (!rwhv)
     return gfx::NativeViewAccessible();
@@ skipping 251 matching lines @@
         gesture_event.data.scrollUpdate.inertialPhase ==
             blink::WebGestureEvent::MomentumPhase) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content