content/public/common/DEPS - Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/DEPS

Issue 2165523004: Force MimeHandlerView to always use BrowserPlugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing lazyboy@'s and lfg@'s comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 specific_include_rules = {	1 specific_include_rules = {

2 ".*\.cc": [	2 ".*\.cc": [

3 "+content/common",	3 "+content/common",

4 ],	4 ],

	5 "browser_plugin_guest_mode.cc": [

	6 "+content/public/browser"
	lfg 2016/07/28 18:29:31 This is wrong. We shouldn't be including browser i This is wrong. We shouldn't be including browser into common. Please, add a new file in content/public/browser/ to do this check. EhsanK 2016/07/29 20:23:17 Acknowledged. Show quoted text On 2016/07/28 18:29:31, lfg wrote: > This is wrong. We shouldn't be including browser into common. Please, add a new > file in content/public/browser/ to do this check. Acknowledged.
	7 ],

5 }	8 }

OLD	NEW