[parser] More CHECK_OK cleanup.

[parser] More CHECK_OK cleanup.

In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=

Committed: https://crrev.com/cde66a896e7547fd4bda4b1cd0ff22c75ddea487
Cr-Commit-Position: refs/heads/master@{#37878}

[neis, 2016-07-19 09:56:25]

Description was changed from

==========
[parser] More CHECK_OK cleanup.

In parser.cc, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=
==========

to

==========
[parser] More CHECK_OK cleanup.

In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we
need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=
==========

[nickie, 2016-07-19 10:56:07]

LGTM, with one very minor comment.

https://codereview.chromium.org/2165513004/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2165513004/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:324: if (failed_) return NULL;  \
Well, since you changed NULL to nullptr in line 312...  :-)

[neis, 2016-07-19 15:21:21]

https://codereview.chromium.org/2165513004/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/2165513004/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:324: if (failed_) return NULL;  \
On 2016/07/19 10:56:07, nickie wrote:
> Well, since you changed NULL to nullptr in line 312...  :-)

Done.

[adamk, 2016-07-19 18:52:58]

lgtm, nice cleanup

[neis, 2016-07-19 18:59:13]

The CQ bit was checked by neis@chromium.org

[neis, 2016-07-19 18:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org
Link to the patchset: https://codereview.chromium.org/2165513004/#ps20001
(title: "Niko's comment.")

[commit-bot: I haz the power, 2016-07-19 18:59:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 19:01:05]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9344)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9314)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9286)

[neis, 2016-07-19 19:21:47]

The CQ bit was checked by neis@chromium.org

[neis, 2016-07-19 19:21:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org, adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2165513004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-19 19:21:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:45:57]

Description was changed from

==========
[parser] More CHECK_OK cleanup.

In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we
need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=
==========

to

==========
[parser] More CHECK_OK cleanup.

In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we
need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-07-19 19:45:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 19:47:53]

Description was changed from

==========
[parser] More CHECK_OK cleanup.

In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we
need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=
==========

to

==========
[parser] More CHECK_OK cleanup.

In parser.{cc,h}, replace CHECK_OK_CUSTOM by CHECK_OK_VOID, as that's all we
need.
Use this to convert all void* functions to void.

R=adamk@chromium.org, nikolaos@chromium.org
BUG=

Committed: https://crrev.com/cde66a896e7547fd4bda4b1cd0ff22c75ddea487
Cr-Commit-Position: refs/heads/master@{#37878}
==========

[commit-bot: I haz the power, 2016-07-19 19:47:54]

Patchset 3 (id:??) landed as
https://crrev.com/cde66a896e7547fd4bda4b1cd0ff22c75ddea487
Cr-Commit-Position: refs/heads/master@{#37878}