Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2165513003: Remove old_login_managers from PasswordManager::CreatePendingLoginManagers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove outdated comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 17e8d65ee9effb24f00c84e8206f0fe80dc97af5..b8ffb02d5a9e793775c52b6ca0bee834c2d898dd 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -487,10 +487,6 @@ void PasswordManager::CreatePendingLoginManagers(
pending_login_managers_.size());
}
- // Copy the weak pointers to the currently known login managers for comparison
- // against the newly added.
- std::vector<PasswordFormManager*> old_login_managers(
- pending_login_managers_.get());
for (std::vector<PasswordForm>::const_iterator iter = forms.begin();
iter != forms.end(); ++iter) {
// Don't involve the password manager if this form corresponds to
@@ -499,7 +495,7 @@ void PasswordManager::CreatePendingLoginManagers(
base::CompareCase::SENSITIVE))
continue;
bool old_manager_found = false;
- for (const auto& old_manager : old_login_managers) {
+ for (const auto& old_manager : pending_login_managers_.get()) {
if (old_manager->DoesManage(*iter) !=
PasswordFormManager::RESULT_COMPLETE_MATCH) {
continue;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698