Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2165503002: Add UMA stats for storage manager for Chrome OS. (Closed)

Created:
4 years, 5 months ago by fukino
Modified:
4 years, 5 months ago
Reviewers:
stevenjb, rkaplow, michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA stats for storage manager for Chrome OS. Record user actions when: - User clicks the storage management button in chrome://settings - User clicks links to manage storage items on storage manager BUG=629433 TEST=manually confirmed that expected logs were recorded in chrome://user-actions. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e50b2670f3ad15f999eb4881125dfb90d45b62e5 Cr-Commit-Position: refs/heads/master@{#406595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.js View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
fukino
Could you take a look? stevenjb@ for chrome/browser/options rkaplow@ for tools/metrics/actions/actions.xml Thanks!
4 years, 5 months ago (2016-07-19 08:34:34 UTC) #4
rkaplow
lgtm
4 years, 5 months ago (2016-07-19 15:28:54 UTC) #5
stevenjb
+michaelpg@ who is converting the device settings section (which includes the storage overlay) to the ...
4 years, 5 months ago (2016-07-20 16:07:18 UTC) #11
fukino
I've just started working on porting storage manager to MD settings for M54. https://bugs.chromium.org/p/chromium/issues/detail?id=629438 I'll ...
4 years, 5 months ago (2016-07-20 16:36:58 UTC) #12
stevenjb
I see, OK. lgtm then. FYI: I update an issue that was created to discuss ...
4 years, 5 months ago (2016-07-20 16:51:36 UTC) #13
fukino
Thank you! I'll watch the issue and follow the strategy to port UMA metrics.
4 years, 5 months ago (2016-07-20 17:06:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165503002/1
4 years, 5 months ago (2016-07-20 17:08:21 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 17:16:48 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:18:15 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e50b2670f3ad15f999eb4881125dfb90d45b62e5
Cr-Commit-Position: refs/heads/master@{#406595}

Powered by Google App Engine
This is Rietveld 408576698