src/IceGlobalContext.cpp - Issue 2165493002: Subzero: Fixed deadlock with _start but no globals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalContext.cpp

Issue 2165493002: Subzero: Fixed deadlock with _start but no globals (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalContext.cpp

diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp

index 349db7cc4ff4bb7db75c5233ce3d3ec1f318a91b..5ece81b31d950e123a53400c5f15aaec89e17f10 100644

--- a/src/IceGlobalContext.cpp

+++ b/src/IceGlobalContext.cpp

@@ -298,9 +298,9 @@ static constexpr size_t DefaultOptQWakeupSize = GlobalContext::MaxOptQSize >> 1;

GlobalContext::GlobalContext(Ostream *OsDump, Ostream *OsEmit, Ostream *OsError,

ELFStreamer *ELFStr)

- : Strings(new StringPool()), ConstPool(new ConstantPool()), ErrorStatus(),

- StrDump(OsDump), StrEmit(OsEmit), StrError(OsError), IntrinsicsInfo(this),

- ObjectWriter(),

+ : GlobalsReceived(false), Strings(new StringPool()),

+ ConstPool(new ConstantPool()), ErrorStatus(), StrDump(OsDump),

+ StrEmit(OsEmit), StrError(OsError), IntrinsicsInfo(this), ObjectWriter(),

OptQWakeupSize(std::max(DefaultOptQWakeupSize,

size_t(getFlags().getNumTranslationThreads()))),

OptQ(/*Sequential=*/getFlags().isSequential(),

« src/IceASanInstrumentation.cpp ('K') | « src/IceGlobalContext.h ('k') | tests_lit/asan_tests/no_globals.ll » ('j') | tests_lit/asan_tests/no_globals.ll » ('J')