Subzero: Fixed deadlock with _start but no globals

src/IceGlobalContext.h

 //===- subzero/src/IceGlobalContext.h - Global context defs -----*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 464 matching lines @@
 
   void setDisposeGlobalVariablesAfterLowering(bool Value) {
     DisposeGlobalVariablesAfterLowering = Value;
   }
   /// @}
 
   LockedPtr<StringPool> getStrings() const {
     return LockedPtr<StringPool>(Strings.get(), &StringsLock);
   }
 
+  LockedPtr<VariableDeclarationList> getGlobals() {
+    return LockedPtr<VariableDeclarationList>(&Globals, &InitAllocLock);
+  }
+
   /// Number of function blocks that can be queued before waiting for
   /// translation
   /// threads to consume.
   static constexpr size_t MaxOptQSize = 1 << 16;
 
 private:
   // Try to ensure mutexes are allocated on separate cache lines.
 
   // Destructors collaborate with Allocator
   ICE_CACHELINE_BOUNDARY;
@@ skipping 110 matching lines @@
     return LockedPtr<TimerList>(&Timers, &TimerLock);
   }
   LockedPtr<DestructorArray> getDestructors() {
     return LockedPtr<DestructorArray>(&Destructors, &DestructorsLock);
   }
 
   void accumulateGlobals(std::unique_ptr<VariableDeclarationList> Globls) {
     LockedPtr<VariableDeclarationList> _(&Globals, &InitAllocLock);
     if (Globls != nullptr) {
       Globals.merge(Globls.get());
+      if (!BuildDefs::minimal() && Instrumentor != NULL)

[Jim Stichnoth, 2016/07/19 22:39:00]

nullptr

[tlively, 2016/07/19 23:20:14]

Done.

+        Instrumentor->setHasSeenGlobals();
     }
   }
 
   void lowerGlobalsIfNoCodeHasBeenSeen() {
     if (HasSeenCode)
       return;
     constexpr char NoSuffix[] = "";
     lowerGlobals(NoSuffix);
     HasSeenCode = true;
   }
@@ skipping 67 matching lines @@
   explicit OstreamLocker(GlobalContext *Ctx) : Ctx(Ctx) { Ctx->lockStr(); }
   ~OstreamLocker() { Ctx->unlockStr(); }
 
 private:
   GlobalContext *const Ctx;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEGLOBALCONTEXT_H