tests_lit/asan_tests/no_globals.ll - Issue 2165493002: Subzero: Fixed deadlock with _start but no globals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/asan_tests/no_globals.ll

Issue 2165493002: Subzero: Fixed deadlock with _start but no globals (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; Check that Subzero can instrument _start when there are no globals
	Jim Stichnoth 2016/07/19 14:04:13 Can you add a more complete description of why thi Can you add a more complete description of why this test is here? Specifically about the possibility of deadlock when there are no global initializers and _start is the first function. tlively 2016/07/19 22:27:04 Done. Show quoted text On 2016/07/19 14:04:13, stichnot wrote: > Can you add a more complete description of why this test is here? Specifically > about the possibility of deadlock when there are no global initializers and > _start is the first function. Done.
	2

	3 ; REQUIRES: no_minimal_build

	4

	5 ; RUN: %p2i -i %s --args -verbose=inst -fsanitize-address \

	6 ; RUN: \| FileCheck --check-prefix=DUMP %s

	7

	8 define void @_start(i32 %arg) {

	9 ret void

	10 }

	11

	12 ; DUMP-LABEL: ================ Instrumented CFG ================
	Jim Stichnoth 2016/07/19 14:04:13 Can the tested output be made less specific? I th Can the tested output be made less specific? I thought it was a deadlock issue, so would simply DUMP: __asan_init be a sufficient test? (But be sure to verify that it fails with the old code and succeeds with the CL, before taking my suggestion...) I say this because the dump output format isn't strongly guaranteed to be stable over time. For example, we might want to change the "Instrumented CFG" string, or the number of '=' characters, etc. tlively 2016/07/19 22:27:04 Done. Show quoted text On 2016/07/19 14:04:13, stichnot wrote: > Can the tested output be made less specific? > > I thought it was a deadlock issue, so would simply > DUMP: __asan_init > be a sufficient test? > > (But be sure to verify that it fails with the old code and succeeds with the CL, > before taking my suggestion...) > > I say this because the dump output format isn't strongly guaranteed to be stable > over time. For example, we might want to change the "Instrumented CFG" string, > or the number of '=' characters, etc. Done.
	13 ; DUMP-NEXT: define void @_start(i32 %arg) {

	14 ; DUMP-NEXT: __0:

	15 ; DUMP-NEXT: call void @__asan_init(i32 0, i32 @__$rz_array, i32 @__$rz_sizes)

	16 ; DUMP-NEXT: ret void

	17 ; DUMP-NEXT: }

OLD	NEW

« src/IceASanInstrumentation.cpp ('K') | « src/IceGlobalContext.cpp ('k') | no next file » | no next file with comments »