Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2165473002: MD History: Close the item overflow menu when search results change (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_slash_command
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Close the item overflow menu when new results load in This fixes an issue where it was possible to have the menu open for a history item which is no longer visible. BUG=626231 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0686269cb57e496229d19ec3b1c48fb68d2b5884 Cr-Commit-Position: refs/heads/master@{#407017}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Close unconditionally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/resources/md_history/list_container.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_overflow_menu_test.js View 1 2 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
tsergeant
4 years, 5 months ago (2016-07-19 05:51:38 UTC) #3
calamity
lgtm
4 years, 5 months ago (2016-07-21 05:24:30 UTC) #8
tsergeant
This now unconditionally closes the menu when new results load in. This is easier to ...
4 years, 5 months ago (2016-07-21 08:14:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165473002/40001
4 years, 5 months ago (2016-07-22 03:15:58 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-22 03:22:42 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:27:20 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0686269cb57e496229d19ec3b1c48fb68d2b5884
Cr-Commit-Position: refs/heads/master@{#407017}

Powered by Google App Engine
This is Rietveld 408576698