Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2165463003: Elements with an ARIA role of treeitem should be able to get their accessible name from their conte… (Closed)

Created:
4 years, 5 months ago by nektarios
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni, aboxhall
CC:
dmazzoni, aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, jam, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elements with an ARIA role of treeitem should be able to get their accessible name from their contents. ARIA Spec 1.1 says that elements with a role of "treeitem" should get their accessible name either "from author" or "from contents". We didn't support "from contents". BUG=601933 R=dmazzoni@chromium.org, aboxhall@chromium.org TESTED=browser test Committed: https://crrev.com/e4bce828f9d8b7674497603d2ca02649923abbd4 Cr-Commit-Position: refs/heads/master@{#406579}

Patch Set 1 #

Patch Set 2 : Fixed test expectations. #

Messages

Total messages: 16 (9 generated)
nektarios
4 years, 5 months ago (2016-07-19 19:04:20 UTC) #1
dmazzoni
lgtm
4 years, 5 months ago (2016-07-19 19:09:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165463003/20001
4 years, 5 months ago (2016-07-19 21:52:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/106854)
4 years, 5 months ago (2016-07-20 00:32:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165463003/20001
4 years, 5 months ago (2016-07-20 15:52:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 16:25:20 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 16:27:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e4bce828f9d8b7674497603d2ca02649923abbd4
Cr-Commit-Position: refs/heads/master@{#406579}

Powered by Google App Engine
This is Rietveld 408576698