Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2165443002: [ios] Reset SSLStatus to default when navigation fails. (Closed)

Created:
4 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 5 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Reset SSLStatus to default when navigation fails. This prevents showing green SSL lock if previously loaded secure page has failed to load. BUG=628471 Committed: https://crrev.com/b78945177b2845d9197b6f353d39e7d92dc6f2c2 Cr-Commit-Position: refs/heads/master@{#406701}

Patch Set 1 #

Patch Set 2 : GetLastCommittedItem() can be nil #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Eugene But (OOO till 7-30)
4 years, 5 months ago (2016-07-19 01:07:42 UTC) #2
kkhorimoto
lgtm
4 years, 5 months ago (2016-07-19 21:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165443002/1
4 years, 5 months ago (2016-07-19 21:19:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/38199)
4 years, 5 months ago (2016-07-19 21:35:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165443002/1
4 years, 5 months ago (2016-07-19 21:58:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/38242) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-19 22:20:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165443002/20001
4 years, 5 months ago (2016-07-20 21:58:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 22:48:42 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:50:05 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b78945177b2845d9197b6f353d39e7d92dc6f2c2
Cr-Commit-Position: refs/heads/master@{#406701}

Powered by Google App Engine
This is Rietveld 408576698