Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2165433002: Re-land https://codereview.chromium.org/2108553002/ (Closed)

Created:
4 years, 5 months ago by dsansome
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@reland-2
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Re-land https://codereview.chromium.org/2108553002/ Revert buildbot 361b81b43fc7793b66facd4bac7abe0adb30f3d5. This commit was only added in the 0.8.4 branch, and was never made to master. The bug only happens when starting buildbot with "make start", but we start it directly with twistd in Chrome: http://trac.buildbot.net/ticket/1992 BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d55ae245e3194142a45fb34a7c8e86cbd00d0409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M third_party/buildbot_8_4p1/buildbot/db/pool.py View 5 chunks +1 line, -24 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsansome
4 years, 5 months ago (2016-07-19 01:07:40 UTC) #2
ghost stip (do not use)
lgtm
4 years, 5 months ago (2016-07-20 01:59:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165433002/1
4 years, 5 months ago (2016-07-20 03:37:41 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 03:42:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d55ae245e3194142a45f...

Powered by Google App Engine
This is Rietveld 408576698