Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 216543002: Revert of Remove applyAuthorStyles flag from ShadowRoot. (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
Reviewers:
esprehn, hayato, tasak, dglazkov
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Revert of Remove applyAuthorStyles flag from ShadowRoot. (https://codereview.chromium.org/215313003/) Reason for revert: w3c/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-004.html started to fail. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=w3c/web-platform-tests/shadow-dom/elements-and-dom-objects/shadowroot-object/shadowroot-attributes/test-004.html Original issue's description: > Remove applyAuthorStyles flag from ShadowRoot. > > This re-applies https://src.chromium.org/viewvc/blink?revision=165673&view=revision. > > BUG=357151 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170271 TBR=esprehn@chromium.org,tasak@google.com,hayato@chromium.org,dglazkov@chromium.org NOTREECHECKS=true NOTRY=true BUG=357151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +7 lines, -4 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles.html View 1 chunk +243 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-nested.html View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt View 2 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule.html View 3 chunks +33 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule-expected.txt View 2 chunks +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-wrapper-reclaimed.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/host-wrapper-reclaimed-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/new-style-inserted-into-parent-treescope.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/new-style-inserted-into-parent-treescope-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-nodes.html View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html View 1 chunk +151 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-tree-styles-with-apply-author-styles.html View 1 chunk +84 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/shadow-tree-styles-with-apply-author-styles-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-keyframes.html View 3 chunks +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-keyframes-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/web/tests/data/touch-action-tests.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/data/touch-action-tests.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Remove applyAuthorStyles flag from ShadowRoot.
6 years, 9 months ago (2014-03-28 07:08:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/216543002/1
6 years, 9 months ago (2014-03-28 07:08:07 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 07:08:46 UTC) #3
Message was sent while issue was closed.
Change committed as 170289

Powered by Google App Engine
This is Rietveld 408576698