Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2165413002: Add shadow for md toggle button. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add shadow for md toggle button. BUG=626827 Committed: https://crrev.com/d25f5027f3d4224a4c97668a128a6656ed492814 Cr-Commit-Position: refs/heads/master@{#407157}

Patch Set 1 #

Total comments: 2

Patch Set 2 : emplace_back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M ui/views/controls/button/toggle_button.cc View 1 3 chunks +29 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Evan Stade
4 years, 5 months ago (2016-07-21 20:47:38 UTC) #2
sadrul
lgtm https://codereview.chromium.org/2165413002/diff/1/ui/views/controls/button/toggle_button.cc File ui/views/controls/button/toggle_button.cc (right): https://codereview.chromium.org/2165413002/diff/1/ui/views/controls/button/toggle_button.cc#newcode89 ui/views/controls/button/toggle_button.cc:89: shadows.emplace(shadows.end(), gfx::Vector2d(0, 1), 5.f, emplace_back instead?
4 years, 5 months ago (2016-07-22 03:35:05 UTC) #3
Evan Stade
https://codereview.chromium.org/2165413002/diff/1/ui/views/controls/button/toggle_button.cc File ui/views/controls/button/toggle_button.cc (right): https://codereview.chromium.org/2165413002/diff/1/ui/views/controls/button/toggle_button.cc#newcode89 ui/views/controls/button/toggle_button.cc:89: shadows.emplace(shadows.end(), gfx::Vector2d(0, 1), 5.f, On 2016/07/22 03:35:05, sadrul wrote: ...
4 years, 5 months ago (2016-07-22 14:03:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165413002/20001
4 years, 5 months ago (2016-07-22 14:03:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 14:47:09 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 14:49:14 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d25f5027f3d4224a4c97668a128a6656ed492814
Cr-Commit-Position: refs/heads/master@{#407157}

Powered by Google App Engine
This is Rietveld 408576698