Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2165383002: Fix for local function element identifiers. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for local function element identifiers. Slightly enhance the incremental invalidation test for constants. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b7ce35e3b2e57a887038047ac26decce42f0632e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -18 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +79 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-21 19:17:57 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-21 19:31:24 UTC) #2
scheglov
4 years, 5 months ago (2016-07-21 19:47:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7ce35e3b2e57a887038047ac26decce42f0632e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698