Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2165373002: [Chromedriver] Disable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic (Closed)

Created:
4 years, 5 months ago by gmanikpure
Modified:
4 years, 5 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Disable ImplicitWaitTest.testShouldImplicitlyWaitForASingleElement on ChromePublic BUG=chromedriver:998 Committed: https://crrev.com/41963396e6ad131c5ab8c50927f21f0a974c1129 Cr-Commit-Position: refs/heads/master@{#406954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/chromedriver/test/test_expectations View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
gmanikpure
This test again started failing on android chromium. Hence disabling it.
4 years, 5 months ago (2016-07-21 18:48:46 UTC) #2
samuong
lgtm
4 years, 5 months ago (2016-07-21 19:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165373002/1
4 years, 5 months ago (2016-07-21 19:06:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99793)
4 years, 5 months ago (2016-07-21 19:34:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165373002/1
4 years, 5 months ago (2016-07-21 19:37:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99846)
4 years, 5 months ago (2016-07-21 19:54:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165373002/1
4 years, 5 months ago (2016-07-21 20:00:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99879)
4 years, 5 months ago (2016-07-21 20:13:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165373002/1
4 years, 5 months ago (2016-07-21 21:09:40 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 21:40:09 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:43:08 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/41963396e6ad131c5ab8c50927f21f0a974c1129
Cr-Commit-Position: refs/heads/master@{#406954}

Powered by Google App Engine
This is Rietveld 408576698