Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2165363002: Update Reader Mode text on width change (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Reader Mode text on width change Destroy and recreate the text resource used by the Reader Mode panel when the width of the layout changes. This will truncate text that cannot fit on-screen during rotation. BUG=559126 Committed: https://crrev.com/98fdddb4863a0bc3cfc08271d4189c5a6648a0cc Cr-Commit-Position: refs/heads/master@{#406969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/ReaderModePanel.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mdjones
ptal
4 years, 5 months ago (2016-07-21 18:34:52 UTC) #2
Theresa
lgtm
4 years, 5 months ago (2016-07-21 19:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165363002/1
4 years, 5 months ago (2016-07-21 20:19:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/99887)
4 years, 5 months ago (2016-07-21 20:35:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165363002/1
4 years, 5 months ago (2016-07-21 20:42:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:27:09 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:31:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98fdddb4863a0bc3cfc08271d4189c5a6648a0cc
Cr-Commit-Position: refs/heads/master@{#406969}

Powered by Google App Engine
This is Rietveld 408576698