Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2165323002: Fix SkScalerContext_FreeType::generateFontMetrics. (Closed)

Created:
4 years, 5 months ago by bungeman-skia
Modified:
4 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkScalerContext_FreeType::generateFontMetrics. SkScalerContext::generateFontMetrics implementations should not attempt to take into account skew. This implementation should correctly handle bitmap fonts as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165323002 Committed: https://skia.googlesource.com/skia/+/5379051ee77f6d70f7d0554a10fd1c61a63b9da9

Patch Set 1 #

Patch Set 2 : Clean up gm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -42 lines) Patch
M gm/coloremoji.cpp View 1 3 chunks +22 lines, -18 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 5 chunks +15 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bungeman-skia
This is kind of a follow up to the last CL where bitmaps are rotated. ...
4 years, 5 months ago (2016-07-21 19:39:52 UTC) #4
mtklein
lgtm
4 years, 5 months ago (2016-07-21 19:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165323002/20001
4 years, 5 months ago (2016-07-21 19:58:38 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 20:32:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5379051ee77f6d70f7d0554a10fd1c61a63b9da9

Powered by Google App Engine
This is Rietveld 408576698