Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 21653002: Cleanups to the refactored extension activity log code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix end-to-end test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_actions.h
diff --git a/chrome/browser/extensions/activity_log/activity_actions.h b/chrome/browser/extensions/activity_log/activity_actions.h
index c867704b9f29d7d18994283f9194a01d35ef77ce..d68a2d07987097b8e418237bc0619a8d5c15b99d 100644
--- a/chrome/browser/extensions/activity_log/activity_actions.h
+++ b/chrome/browser/extensions/activity_log/activity_actions.h
@@ -33,7 +33,10 @@ class Action : public base::RefCountedThreadSafe<Action> {
ACTION_CONTENT_SCRIPT = 3,
ACTION_DOM_ACCESS = 4,
ACTION_DOM_EVENT = 5,
- ACTION_DOM_XHR = 6,
+ // Type 6 is reserved: It was for ACTION_DOM_XHR but that was never
+ // actually used. In the future any injected XHRs, once tracked, will be
+ // classified as ACTION_DOM_ACCESS--no separate type is needed since
+ // api_name is sufficient for distinguishing.
felt 2013/08/02 00:41:53 I am fine with just making ACTION_WEB_REQUEST=6 at
mvrable 2013/08/02 03:33:21 Done.
ACTION_WEB_REQUEST = 7,
};
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698