Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: chrome/test/data/extensions/api_test/activity_log_private/test/test.js

Issue 21653002: Cleanups to the refactored extension activity log code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clarify comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/chrome_render_message_filter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/activity_log_private/test/test.js
diff --git a/chrome/test/data/extensions/api_test/activity_log_private/test/test.js b/chrome/test/data/extensions/api_test/activity_log_private/test/test.js
index cf7af969256ddea05551a96ad58d8d2ea872f10e..45b5f8cfdbb304805567a320e25de6cbdc3af4d3 100644
--- a/chrome/test/data/extensions/api_test/activity_log_private/test/test.js
+++ b/chrome/test/data/extensions/api_test/activity_log_private/test/test.js
@@ -189,9 +189,7 @@ testCases.push({
'api_tab_updated_incognito',
function response() { });
},
- // TODO(mvrable): set this back to true to test the URL values when incognito
- // cleaning is working correctly for HTMLDocument.write (crbug.com/253368).
- is_incognito: false,
+ is_incognito: true,
expected_activity: [
'windows.create',
'tabs.onUpdated',
@@ -299,9 +297,7 @@ testCases.push({
'dom_tab_updated_incognito',
function response() { });
},
- // TODO(mvrable): set this back to true to test the URL values when incognito
- // cleaning is working correctly for DOM logging (crbug.com/253368).
- is_incognito: false,
+ is_incognito: true,
expected_activity: domExpectedActivityIncognito
});
« no previous file with comments | « chrome/browser/renderer_host/chrome_render_message_filter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698