Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc

Issue 21653002: Cleanups to the refactored extension activity log code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clarify comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
diff --git a/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc b/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
index 0169a3ec1326d727079c900b978af4859b1a470e..6ec8916721811203cf6beb0001882477b5cf2e36 100644
--- a/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
+++ b/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
@@ -11,7 +11,12 @@ namespace constants = activity_log_constants;
namespace {
-// We should log the arguments to these API calls.
+// We should log the arguments to these API calls. Be careful when
+// constructing this whitelist to not keep arguments that might compromise
+// privacy by logging too much data to the activity log.
+//
+// TODO(mvrable): The contents of this whitelist should be reviewed and
+// expanded as needed.
const char* kAlwaysLog[] = {"extension.connect", "extension.sendMessage",
"tabs.executeScript", "tabs.insertCSS"};
@@ -32,7 +37,6 @@ scoped_refptr<Action> StreamWithoutArgsUIPolicy::ProcessArguments(
scoped_refptr<Action> action) const {
if (action->action_type() == Action::ACTION_DOM_ACCESS ||
action->action_type() == Action::ACTION_DOM_EVENT ||
- action->action_type() == Action::ACTION_DOM_XHR ||
arg_whitelist_api_.find(action->api_name()) != arg_whitelist_api_.end()) {
// No stripping of arguments
} else {
« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log.cc ('k') | chrome/browser/renderer_host/chrome_render_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698