chrome/browser/extensions/activity_log/activity_actions.cc - Issue 21653002: Cleanups to the refactored extension activity log code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.cc

Issue 21653002: Cleanups to the refactored extension activity log code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Clarify comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/activity_log/activity_actions.cc

diff --git a/chrome/browser/extensions/activity_log/activity_actions.cc b/chrome/browser/extensions/activity_log/activity_actions.cc

index 117f0aafb6e2e37c7eaffd461afee0acd92da54b..1d792255900452d326b57088ac45880b9416e6d4 100644

--- a/chrome/browser/extensions/activity_log/activity_actions.cc

+++ b/chrome/browser/extensions/activity_log/activity_actions.cc

@@ -205,7 +205,6 @@ scoped_ptr<ExtensionActivity> Action::ConvertToExtensionActivity() {

}

case ACTION_DOM_EVENT:

- case ACTION_DOM_XHR:

case ACTION_DOM_ACCESS:

case ACTION_CONTENT_SCRIPT:

case ACTION_WEB_REQUEST: {

@@ -268,9 +267,6 @@ std::string Action::PrintForDebug() {

case ACTION_DOM_EVENT:

result += "dom_event";

break;

- case ACTION_DOM_XHR:

- result += "dom_xhr";

- break;

case ACTION_DOM_ACCESS:

result += "dom_access";

break;