Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 21653002: Cleanups to the refactored extension activity log code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clarify comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_
6 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_ 6 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 15 matching lines...) Expand all
26 public: 26 public:
27 // Types of log entries that can be stored. The numeric values are stored in 27 // Types of log entries that can be stored. The numeric values are stored in
28 // the database, so keep them stable. Append values only. 28 // the database, so keep them stable. Append values only.
29 enum ActionType { 29 enum ActionType {
30 ACTION_API_CALL = 0, 30 ACTION_API_CALL = 0,
31 ACTION_API_EVENT = 1, 31 ACTION_API_EVENT = 1,
32 ACTION_API_BLOCKED = 2, 32 ACTION_API_BLOCKED = 2,
33 ACTION_CONTENT_SCRIPT = 3, 33 ACTION_CONTENT_SCRIPT = 3,
34 ACTION_DOM_ACCESS = 4, 34 ACTION_DOM_ACCESS = 4,
35 ACTION_DOM_EVENT = 5, 35 ACTION_DOM_EVENT = 5,
36 ACTION_DOM_XHR = 6, 36 ACTION_WEB_REQUEST = 6,
37 ACTION_WEB_REQUEST = 7,
38 }; 37 };
39 38
40 // A useful shorthand for methods that take or return collections of Action 39 // A useful shorthand for methods that take or return collections of Action
41 // objects. 40 // objects.
42 typedef std::vector<scoped_refptr<Action> > ActionVector; 41 typedef std::vector<scoped_refptr<Action> > ActionVector;
43 42
44 // Creates a new activity log Action object. The extension_id, time, and 43 // Creates a new activity log Action object. The extension_id, time, and
45 // type are immutable. All other fields can be filled in with the 44 // type are immutable. All other fields can be filled in with the
46 // accessors/mutators below. 45 // accessors/mutators below.
47 Action(const std::string& extension_id, 46 Action(const std::string& extension_id,
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 GURL arg_url_; 123 GURL arg_url_;
125 bool arg_incognito_; 124 bool arg_incognito_;
126 scoped_ptr<DictionaryValue> other_; 125 scoped_ptr<DictionaryValue> other_;
127 126
128 DISALLOW_COPY_AND_ASSIGN(Action); 127 DISALLOW_COPY_AND_ASSIGN(Action);
129 }; 128 };
130 129
131 } // namespace extensions 130 } // namespace extensions
132 131
133 #endif // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_ 132 #endif // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698