chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 216523005: show avatar bubble in edit mode on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 216523005: show avatar bubble in edit mode on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 3ea60f66b0c005233bc0ddbb7cc7dd5ec73efe1b..607bf72bee8a52e4affa7bd7106e819092a4ca43 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -708,7 +708,7 @@ void BrowserWindowCocoa::ShowAvatarBubble(WebContents* web_contents,

void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

AvatarBubbleMode mode) {

AvatarBaseController* controller = [controller_ avatarButtonController];

- [controller showAvatarBubble:[controller buttonView]];

+ [controller showAvatarBubble:[controller buttonView] mode: mode];

Alexei Svitkine (slow) 2014/03/28 14:07:31 Nit: Remove space after :.

guohui 2014/03/28 15:28:00 Done.

}

void BrowserWindowCocoa::ShowPasswordGenerationBubble(