Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216523005: show avatar bubble in edit mode on mac (Closed)

Created:
6 years, 9 months ago by guohui
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

show avatar bubble in edit mode on mac BUG=335208 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260221

Patch Set 1 : #

Total comments: 8

Patch Set 2 : nits fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M chrome/browser/ui/cocoa/browser/avatar_base_controller.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_base_controller.mm View 1 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/profile_chooser_controller.h View 1 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
guohui
Hey, could you please take a look at the CL? Thanks, Hui
6 years, 9 months ago (2014-03-28 13:19:06 UTC) #1
Alexei Svitkine (slow)
LGTM with nits https://codereview.chromium.org/216523005/diff/2/chrome/browser/ui/cocoa/browser/avatar_base_controller.h File chrome/browser/ui/cocoa/browser/avatar_base_controller.h (right): https://codereview.chromium.org/216523005/diff/2/chrome/browser/ui/cocoa/browser/avatar_base_controller.h#newcode44 chrome/browser/ui/cocoa/browser/avatar_base_controller.h:44: mode:(BrowserWindow::AvatarBubbleMode)mode; Nit: withMode: https://codereview.chromium.org/216523005/diff/2/chrome/browser/ui/cocoa/browser/avatar_base_controller.mm File chrome/browser/ui/cocoa/browser/avatar_base_controller.mm ...
6 years, 9 months ago (2014-03-28 14:07:31 UTC) #2
guohui
https://codereview.chromium.org/216523005/diff/2/chrome/browser/ui/cocoa/browser/avatar_base_controller.h File chrome/browser/ui/cocoa/browser/avatar_base_controller.h (right): https://codereview.chromium.org/216523005/diff/2/chrome/browser/ui/cocoa/browser/avatar_base_controller.h#newcode44 chrome/browser/ui/cocoa/browser/avatar_base_controller.h:44: mode:(BrowserWindow::AvatarBubbleMode)mode; On 2014/03/28 14:07:31, Alexei Svitkine wrote: > Nit: ...
6 years, 9 months ago (2014-03-28 15:28:00 UTC) #3
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 9 months ago (2014-03-28 15:28:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/216523005/30001
6 years, 9 months ago (2014-03-28 15:33:52 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:56:20 UTC) #6
Message was sent while issue was closed. 
Change committed as 260221

Powered by Google App Engine
This is Rietveld 408576698