Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 216523004: Cleanup scanner character streams. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Cleanup scanner character streams. - GenericStringUtf16CharacterStream::start_position_ was unused. - GenericStringUtf16CharacterStream inherits from BufferedUtf16CharacterStream, so no need to initialize buffer_cursor_ and buffer_end_ twice (this makes it clearer which class in the inheritance chain takes care of which variables). R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/scanner-character-streams.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/scanner-character-streams.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
yangguo, again a tiny cleanup CL, ptal.
6 years, 9 months ago (2014-03-28 13:00:09 UTC) #1
Yang
lgtm
6 years, 9 months ago (2014-03-28 13:00:38 UTC) #2
marja
6 years, 9 months ago (2014-03-28 13:11:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698