Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: Source/core/html/HTMLFormElement.cpp

Issue 216523002: Oilpan: Replace most of RefPtrs for Event objects with oilpan's transition types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFormElement.cpp
diff --git a/Source/core/html/HTMLFormElement.cpp b/Source/core/html/HTMLFormElement.cpp
index 2517a6f7e946eabead60f30be855b2c9cfc824d0..abb17ff8e3e7f5528ecc5774d614f3575fc1dccc 100644
--- a/Source/core/html/HTMLFormElement.cpp
+++ b/Source/core/html/HTMLFormElement.cpp
@@ -435,7 +435,7 @@ void HTMLFormElement::requestAutocomplete()
void HTMLFormElement::finishRequestAutocomplete(AutocompleteResult result)
{
- RefPtr<Event> event;
+ RefPtrWillBeRawPtr<Event> event = nullptr;
if (result == AutocompleteResultSuccess)
event = Event::create(EventTypeNames::autocomplete);
else if (result == AutocompleteResultErrorDisabled)
@@ -444,6 +444,8 @@ void HTMLFormElement::finishRequestAutocomplete(AutocompleteResult result)
event = AutocompleteErrorEvent::create("cancel");
else if (result == AutocompleteResultErrorInvalid)
event = AutocompleteErrorEvent::create("invalid");
+ else
+ ASSERT_NOT_REACHED();
event->setTarget(this);
m_pendingAutocompleteEvents.append(event.release());
@@ -455,7 +457,7 @@ void HTMLFormElement::finishRequestAutocomplete(AutocompleteResult result)
void HTMLFormElement::requestAutocompleteTimerFired(Timer<HTMLFormElement>*)
{
- Vector<RefPtr<Event> > pendingEvents;
+ WillBeHeapVector<RefPtrWillBeMember<Event> > pendingEvents;
m_pendingAutocompleteEvents.swap(pendingEvents);
for (size_t i = 0; i < pendingEvents.size(); ++i)
dispatchEvent(pendingEvents[i].release());

Powered by Google App Engine
This is Rietveld 408576698