Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2165223002: Revert of [Intepreter] Always use BytecodeGraphBuilder when --turbo-from-bytecode (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Intepreter] Always use BytecodeGraphBuilder when --turbo-from-bytecode (patchset #3 id:80001 of https://codereview.chromium.org/2156753002/ ) Reason for revert: Breaks tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10758 Original issue's description: > [Intepreter] Always use BytecodeGraphBuilder when --turbo-from-bytecode > > Always use the BytecodeGraphBuilder when the --turbo-from-bytecode > is enabled, assuming the function should be compiled for Ignition. > Adds a new MaybeOptimizeIgnition function to runtime-profiler > which is called if the function should be optimized from bytecode > rather than going via full-codegen. > > BUG=v8:4280 > > Committed: https://crrev.com/9ca7db914be88e6792a88eab4a1988ee031d70c4 > Cr-Commit-Position: refs/heads/master@{#37921} TBR=mstarzinger@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/714b95f0ff400b5eba5b47e861d860ad827da508 Cr-Commit-Position: refs/heads/master@{#37925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -138 lines) Patch
M src/compiler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler.cc View 5 chunks +4 lines, -31 lines 0 comments Download
M src/runtime-profiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 5 chunks +10 lines, -63 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -31 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [Intepreter] Always use BytecodeGraphBuilder when --turbo-from-bytecode
4 years, 5 months ago (2016-07-21 08:39:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165223002/1
4 years, 5 months ago (2016-07-21 08:40:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 08:40:19 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 08:43:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/714b95f0ff400b5eba5b47e861d860ad827da508
Cr-Commit-Position: refs/heads/master@{#37925}

Powered by Google App Engine
This is Rietveld 408576698