Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2165183002: MD Settings: remove special-casing of links on passwords page (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove special-casing of links on passwords page They should be the same color as other links and have no underline on :hover. R=hcarmona@chromium.org BUG=630067 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2d6e1f491447569b7fd19be8f1d568a56d8cb4e7 Cr-Commit-Position: refs/heads/master@{#406757}

Patch Set 1 : asd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
4 years, 5 months ago (2016-07-21 02:07:42 UTC) #3
hcarmona
lgtm
4 years, 5 months ago (2016-07-21 02:14:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165183002/20001
4 years, 5 months ago (2016-07-21 02:16:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 5 months ago (2016-07-21 03:35:22 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:37:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d6e1f491447569b7fd19be8f1d568a56d8cb4e7
Cr-Commit-Position: refs/heads/master@{#406757}

Powered by Google App Engine
This is Rietveld 408576698