Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2165173002: Only Update the Scale Factor if the Scale Factor Actually Changed (Closed)

Created:
4 years, 5 months ago by robliao
Modified:
4 years, 5 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, tfarina, robliao+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only Update the Scale Factor if the Scale Factor Actually Changed WM_DPICHANGED may fire when the DPI hasn't actually changed. This occurs during initialization with an interaction from EnableChildWindowDpiMessage. For maximized windows, this causes the bounds logic to unset WS_MAXIMIZE from the HWND, which leads to WM_SYSCOMMAND with SC_MAXIMIZE prematurely showing the window, and short-circuting BrowserView::Show() causing it to skip showing the contents of the window because the frame is already visible. BUG=625076 Committed: https://crrev.com/8e164fb9b1df48c5e01540190a108eaaad86feca Cr-Commit-Position: refs/heads/master@{#406962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -15 lines) Patch
M ui/display/win/screen_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/display/win/screen_win.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M ui/display/win/screen_win_unittest.cc View 14 chunks +68 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
robliao
Reviewers: Please review the file patterns by your name. Thanks! oshima: ui/display/* sky: ui/views/*
4 years, 5 months ago (2016-07-21 16:56:27 UTC) #8
sky
LGTM
4 years, 5 months ago (2016-07-21 19:26:32 UTC) #11
oshima
lgtm
4 years, 5 months ago (2016-07-21 22:03:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165173002/1
4 years, 5 months ago (2016-07-21 22:04:14 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:09:47 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:11:10 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e164fb9b1df48c5e01540190a108eaaad86feca
Cr-Commit-Position: refs/heads/master@{#406962}

Powered by Google App Engine
This is Rietveld 408576698