chrome/renderer/chrome_content_renderer_client.cc - Issue 2165133003: Allow forking for POST method (+ test that this works with prerender).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2165133003: Allow forking for POST method (+ test that this works with prerender). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actual CL. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/test/data/prerender/form_that_posts_to_prerendered_echoall.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index ec4c0d63c5aebcf8c33f79a300ff42577c472938..e9593333c701e223f14a215642be4c4bf82f9cfa 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -1063,13 +1063,6 @@ bool ChromeContentRendererClient::ShouldFork(WebLocalFrame* frame,

return true;

}

- // For now, we skip the rest for POST submissions. This is because

- // http://crbug.com/101395 is more likely to cause compatibility issues

- // with hosted apps and extensions than WebUI pages. We will remove this

- // check when cross-process POST submissions are supported.

- if (http_method != "GET")

- return false;

// If |url| matches one of the prerendered URLs, stop this navigation and try

// to swap in the prerendered page on the browser process. If the prerendered

// page no longer exists by the time the OpenURL IPC is handled, a normal